[Combobox] Programmatically selecting a combobox item focuses the component

[macandcheese]

Actual Behavior

When programmatically selecting a combobox item, focus is moved to the Combobox. This differs from how other form components work, where the acted upon component does not gain focus.

Expected Behavior

I wouldn't expect the Combobox to gain focus when programmatically setting the selected value of contained combobox items.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/rNvXGgz?editors=1000

Reproduction Steps

1. Open codepen
2. Click the button to set selected on the combobox item.
3. Notice that the combobox has received focus
4. Repeat for input and slider - those components to not receive focus

Reproduction Version

95

Relevant Info

No response

Regression?

No response

Esri team

Calcite (design)

[driskull]

I think this is the issue; https://github.com/Esri/calcite-components/blob/1b8624e4d2785523bc5670c968065c91b625a3df/src/components/combobox/combobox.tsx#L1027

[driskull]

hey @alisonailea don't close the issue, just label it as installed so that it can get verified.

[github-actions]

Installed and assigned for verification.

[geospatialem]

@alisonailea Can you speak to the skipped tests in filter, input-number, and input?

The fix works well with next.642, but want to make sure the skipped tests are expected.

[github-actions]

Installed and assigned for verification.

[geospatialem]

A good majority of the skip tests have been addressed via #5885, but there still seems to be a skipped test in filter.

@alisonailea It looks like there's one skipped test remaining in filter.e2e.ts per the discussion in https://github.com/Esri/calcite-components/pull/5774/files#r1030924370.

Reassigning to dev for final incorporation.

[driskull]

@alisonailea can you restore the last skipped test?

[github-actions]

Installed and assigned for verification.

[geospatialem]

A good majority of the skip tests have been addressed via #5885, but there still seems to be a skipped test in filter.

@alisonailea It looks like there's one skipped test remaining in filter.e2e.ts per the discussion in https://github.com/Esri/calcite-components/pull/5774/files#r1030924370.

Reassigning to dev for final incorporation.

@alisonailea Can the skipped tests be restored? Reassigning to dev for final incorporation.

[alisonailea]

@geospatialem I just pulled it down and removed the .skip on filter.e2e to see what would happen and it is still failing. I don't know why. I didn't touch this code and this test was failing in main before I did any work.

calcite-filter › filter behavior › updates filtered items after filtering

    expect(received).toHaveLength(expected)

    Expected length: 1
    Received length: 4
    Received array:  [{"description": "developer", "metadata": {"favoriteBand": "MetallicA", "haircolor": "red"}, "name": "Harry", "value": "harry"}, {"description": "developer", "metadata": {"favoriteBand": "Radiohead", "haircolor": "black"}, "name": "Matt", "value": "matt"}, {"description": "developer", "metadata": {"favoriteBand": "The Mars Volta", "haircolor": "black"}, "name": "Franco", "value": "franco"}, {"description": "developer", "metadata": {"favoriteBand": "Hippity Hops", "haircolor": "brown"}, "name": "Jon", "value": "jon"}]

      121 |
      122 |   function assertMatchingItems(filtered: any[], values: string[]): void {
    > 123 |     expect(filtered).toHaveLength(values.length);
          |                      ^
      124 |     values.forEach((value) => expect(filtered.find((element) => element.value === value)).toBeDefined());
      125 |   }

[jcfranco]

I didn't touch this code and this test was failing in main before I did any work.

Seems like unstable tests at play. @alisonailea Can you create a follow-up issue to restore the skipped tests?

[alisonailea]

Follow up issue created: #6311

[geospatialem]

The original issue has been mitigated and verified. With the above follow-up to the filter unstable test, will close out this issue. 👍🏻