fix(button, fab): adjust padding on 'l' scale button to accommodate 'm' scale icon without change in height #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a medium size icon without a change in height
github-actions
bot
added
the
bug
…is present to preserve the height
…sting-height-with-larger-icon
driskull
reviewed
Oct 28, 2022
…nt or not, and handle default appearance when given an invalid option
…sting-height-with-larger-icon
…sting-height-with-larger-icon
…sting-height-with-larger-icon
Elijbet
added
the
pr ready for visual snapshots
eriklharper
added
pr ready for visual snapshots
16 tasks
…sting-height-with-larger-icon
…with-larger-icon' of github.com:Esri/calcite-components into elijbet/5245-l-scale-button/fab-retain-existing-height-with-larger-icon
Elijbet
added
pr ready for visual snapshots
Elijbet
added
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
Elijbet
removed
the
pr ready for visual snapshots
github-actions
bot
added
the
pr ready for visual snapshots
…sting-height-with-larger-icon
Elijbet
added
pr ready for visual snapshots
driskull
approved these changes
Nov 9, 2022
benelan
added
pr ready for visual snapshots
Elijbet
deleted the
elijbet/5245-l-scale-button/fab-retain-existing-height-with-larger-icon
branch
benelan
added a commit
that referenced
this pull request
Nov 11, 2022
* master: (32 commits) 1.0.0-next.627 build(deps): bump semver-regex and screener-storybook (#5741) build(deps): bump stylelint-config-recommended-scss from 7.0.0 to 8.0.0 (#5551) build(deps): bump parse-path and @storybook/storybook-deployer (#5692) build(deps): bump tailwindcss from 3.1.8 to 3.2.2 (#5708) ci(pr-bot): check user login for dependabot instead of actor (#5740) build(deps): bump postcss from 8.4.17 to 8.4.18 (#5508) build(deps): bump concurrently from 7.4.0 to 7.5.0 (#5550) build(deps): bump loader-utils from 1.4.0 to 1.4.1 (#5704) build(deps): bump @typescript-eslint/parser from 5.40.1 to 5.42.1 (#5707) test(value-list): Skip unstable test. (#5738) ci(pr-bot): skip assignment for dependabot PRs (#5737) chore(t9manifest): Fix newline at end of file. (#5718) fix(flow-item): Position back tooltip above (#5688) feat(popover): Escape key should close open popovers. (#5726) docs: update component READMEs (#5545) fix(value-list-item): Prevent scrolling when space is pressed on drag button (#5709) ci(output targets): move patches to postbuild to include them in CCR (#5730) 1.0.0-next.626 fix(button, fab): adjust padding on 'l' scale button to accommodate 'm' scale icon without change in height (#5659) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5245
Summary
Design adjustment on #5521. The height of the
largecomponent changed when a newmedium(24px) icon was introduced. This PR will meet the design recommendation to maintain the 44px height with or without an icon, accounting for both the defaultsolidappearance with aborderandtransparentwithout. Every other appearance option also has a border. Also includes small adjustments for other scales.