Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): Add support for navigating with Home and End keys #5727

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

driskull
Copy link
Member

@driskull driskull commented Nov 9, 2022

Related Issue: #5661

Summary

feat(tabs): Add support for navigating with Home and End keys #5661

@driskull driskull requested a review from a team as a code owner November 9, 2022 23:31
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 9, 2022
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but this needs a test before merging.

Also, shouldn't the PR title be more about adding support for Home/End vs the events themselves?

src/components/tab-nav/tab-nav.tsx Show resolved Hide resolved
@driskull driskull changed the title feat(tabs): Add keyboarding events for Home and End keys feat(tabs): Add support for navigating with Home and End keys Nov 14, 2022
@driskull driskull merged commit 823c429 into master Nov 14, 2022
@driskull driskull deleted the dris0000/tab-home-end-key-support branch November 14, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants