Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action inside Tree item can't be clicked with keyboard Space button #5735

Closed
avkolomeets opened this issue Nov 10, 2022 · 3 comments
Closed

Action inside Tree item can't be clicked with keyboard Space button #5735

avkolomeets opened this issue Nov 10, 2022 · 3 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Milestone
2023 January Prio...

Comments

@avkolomeets
Copy link

avkolomeets commented Nov 10, 2022 •
edited

Actual Behavior

Need to add an action inside a tree item. After focusing and hitting Space, no click event is emitted by the action.
Clicking works when using the mouse, though.

Expected Behavior

Clicking with Space must work for this case.
I know it might conflict with the selection of tree items, but I'm using the tree with selection-mode='none'.

Also when putting a checkbox in the tree item (see the sample below), it works fine, probably because it emits a different event (calciteCheckboxChange).

Reproduction Sample

https://codepen.io/cont-kolomeets/pen/JjZWYwv?editors=100

Reproduction Steps

See the sample above.
(1) Add an action inside a tree child.
(2) Navigate with the keyboard.
(3) Hit Space.
(4) Nothing happens.

Reproduction Version

beta.95

Relevant Info

No response

Regression?

No response

Impact

No response

Esri team

ArcGIS Business/Community Analyst
@avkolomeets avkolomeets added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Nov 10, 2022
@driskull
Copy link
Member

Valid bug. Seems like we need to not preventDefault on the keyboard events when the tree is in selection-mode="none"

@benelan benelan added the ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. label Nov 15, 2022
driskull added a commit that referenced this issue Nov 22, 2022
@driskull
fix(tree-item): Allow space and enter key events when selectionMode i…
265042b 
…s "none". #5735
@driskull driskull mentioned this issue Nov 22, 2022
Merged
@driskull driskull self-assigned this Nov 23, 2022
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 23, 2022
driskull added a commit that referenced this issue Nov 23, 2022
@driskull
fix(tree-item): Allow space and enter key events when selectionMode i…
2fa483b 
…s "none" (#5800)

**Related Issue:** #5735

## Summary

fix(tree-item): Allow space and enter key events when selectionMode is
"none". #5735
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 23, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned driskull Nov 23, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 1, 2022
@geospatialem geospatialem added this to the 2023 January Priorities milestone Dec 1, 2022
@geospatialem
Copy link
Member

Verified in next.652.

verify-actions-tree-item-keyboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
4 participants
@driskull @geospatialem @avkolomeets @benelan