Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alert): support actions-end #5750

Merged
merged 11 commits into from
Nov 21, 2022
Merged

feat(alert): support actions-end #5750

merged 11 commits into from
Nov 21, 2022

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Nov 15, 2022

Related Issue: #2382

Summary

Alert now supports actions-end slot for adding actions to the end of the component, with a recommendation to use two or fewer actions.

@Elijbet Elijbet added the enhancement Issues tied to a new feature or request. label Nov 15, 2022
@Elijbet Elijbet changed the title feat(alert) support actions-end feat(alert): support actions-end Nov 15, 2022
@Elijbet Elijbet assigned Elijbet and unassigned Elijbet Nov 15, 2022
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 15, 2022
@Elijbet Elijbet marked this pull request as ready for review November 15, 2022 03:28
@Elijbet Elijbet requested a review from a team as a code owner November 15, 2022 03:28
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 15, 2022
@Elijbet Elijbet marked this pull request as draft November 15, 2022 17:19
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 21, 2022
@Elijbet Elijbet marked this pull request as ready for review November 21, 2022 19:33
driskull
driskull approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after a couple changes :) 👍

src/components/alert/alert.tsx Show resolved Hide resolved
src/components/alert/alert.tsx Outdated Show resolved Hide resolved
driskull
driskull approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elijbet Elijbet removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 21, 2022
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 21, 2022
@Elijbet Elijbet merged commit 2447e16 into master Nov 21, 2022
@Elijbet Elijbet deleted the elijbet/2382-alert-supports-actions-end branch November 21, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco left review comments

@driskull driskull driskull approved these changes

Assignees

@Elijbet Elijbet

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
Sprint 2022/11/20 - 2022/12/01
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Elijbet @jcfranco @driskull