Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tooltip): Add tooltip open, close, beforeOpen, and beforeClose events #5772

Merged
merged 1 commit into from
Nov 18, 2022
Merged

feat(tooltip): Add tooltip open, close, beforeOpen, and beforeClose events #5772

merged 1 commit into from
Nov 18, 2022

Conversation

driskull
Copy link
Member

Related Issue: #5734

Summary

feat(tooltip): Add tooltip open, close, beforeOpen, and beforeClose events. (#5734)

@driskull driskull added the 2 - in development Issues that are actively being worked on. label Nov 17, 2022
@driskull driskull self-assigned this Nov 17, 2022
@driskull driskull requested a review from a team as a code owner November 17, 2022 01:03
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 17, 2022
Elijbet
Elijbet approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Elijbet Elijbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We're making some adjustments to this pattern to account for cases when --calcite-duration-factor is 0. Still in the works though. We'll update this and all other openClose components after it's installed.

@driskull driskull merged commit 64b5675 into master Nov 18, 2022
@driskull driskull deleted the dris0000/tooltip-open-close-events branch November 18, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elijbet Elijbet Elijbet approved these changes

Assignees

@driskull driskull

Labels
2 - in development Issues that are actively being worked on. enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
Sprint 2022/11/07 - 2022/11/18
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@driskull @Elijbet