Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree-item): Allow space and enter key events when selectionMode is "none" #5800

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

driskull
Copy link
Member

Related Issue: #5735

Summary

fix(tree-item): Allow space and enter key events when selectionMode is "none". #5735

@driskull driskull requested a review from a team as a code owner November 22, 2022 23:23
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 22, 2022
Copy link
Contributor

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@driskull driskull merged commit 2fa483b into master Nov 23, 2022
@driskull driskull deleted the dris0000/tree-space branch November 23, 2022 21:05
benelan added a commit that referenced this pull request Nov 28, 2022
* master:
  docs: update component READMEs (#5810)
  ci(chromatic): use diffThreshold value saved in secrets (#5806)
  1.0.0-next.642
  fix(combobox): 5540 - handle focus (#5774)
  1.0.0-next.641
  fix(tree-item): Allow space and enter key events when selectionMode is "none" (#5800)
  Update CONTRIBUTING.md
  1.0.0-next.640
  fix(input-date-picker): display updated valueAsDate in the two range inputs (#5758)
  docs(tree): Update interface for selectionMode. (#5801)
  docs: update component READMEs (#5804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants