feat(input, input-text, input-number): add attributes autocomplete, accept, multiple, pattern #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and autocomplete properties
github-actions
bot
added
the
enhancement
driskull
reviewed
Nov 23, 2022
| * | ||
| * @mdn [step](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete) | ||
| */ | ||
| @Prop({ reflect: true }) autocomplete?: "string"; |
There was a problem hiding this comment.
@benelan shouldn't it be autocomplete: string;?
We don't need the optional question mark and the type should be string not "string" for these right?
There was a problem hiding this comment.
Do these need to be reflected?
There was a problem hiding this comment.
Woops my bad, fixing. I copy and pasted from the step property which has "any" in quotes for some reason. I'll fix that in a separate PR
Nevermind I remembered step is supposed to be like that
driskull
approved these changes
Nov 23, 2022
|
Good idea, I'll add some coverage. I did test them in the demos |
* master: docs: update component READMEs (#5810) ci(chromatic): use diffThreshold value saved in secrets (#5806) 1.0.0-next.642 fix(combobox): 5540 - handle focus (#5774) 1.0.0-next.641 fix(tree-item): Allow space and enter key events when selectionMode is "none" (#5800) Update CONTRIBUTING.md 1.0.0-next.640 fix(input-date-picker): display updated valueAsDate in the two range inputs (#5758) docs(tree): Update interface for selectionMode. (#5801) docs: update component READMEs (#5804)
benelan
added
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4079
Summary
Adds native input attributes:
calcite-inputfor the types specified on MDNcalcite-inputfor the types specified on MDNcalcite-input-textandcalcite-inputfor the types specified on MDNcalcite-input-number,calcite-input-text, andcalcite-inputfor the types specified on MDNNote
just saw on MDN after committing that Safari may not support
autocomplete:https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#browser_compatibility
Should I remove it from the PR?