Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): restore deprecated scrim background css property #5868

Merged
merged 5 commits into from
Dec 2, 2022
Merged

fix(modal): restore deprecated scrim background css property #5868

merged 5 commits into from
Dec 2, 2022

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #5866

This PR will restore the deprecated --calcite-scrim-background CSS property.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 1, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 1, 2022 16:49
@anveshmekala anveshmekala requested a review from a team as a code owner December 1, 2022 16:49
driskull
driskull approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 1, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 1, 2022
@anveshmekala anveshmekala merged commit 7717127 into master Dec 2, 2022
@anveshmekala anveshmekala deleted the anveshmekala/5866-restore-scrim-background-css-var branch December 2, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
Sprint 2022/12/04 - 2022/12/15
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anveshmekala @driskull