fix(input-time-picker, input-date-picker): internal pickers update when changing locales #5887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5855
Summary
The
effectiveLocale
is kept up to date using a MutationObserver, so it doesn't need to be passed down via attribute.The
input-date-picker
e2e test I added for coverage is kinda funky, but I couldn't think of another way to make sure the internals are being localized. If you have any other ideas I'm happy to add to or change it.