Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flow): Allow nested flows. #5897

Merged
merged 4 commits into from
Dec 6, 2022
Merged

fix(flow): Allow nested flows. #5897

merged 4 commits into from
Dec 6, 2022
+151 −164

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 5, 2022 •
edited

Related Issue: #5896

Summary

fix(flow): Allow nested flow-items.

Allows nesting flows inside other flows.

  • calcite-flow should only use other calcite-flow-items that are not nested inside another nested calcite-flow.
  • This changes filtering the calcite-flow-item calcite-flow-item selector to using closest() to get the closest flow.
  • If the closest flow doesn't match the flow doing the querying then the flow-item is filtered out.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 5, 2022
@driskull driskull marked this pull request as ready for review December 5, 2022 23:21
@driskull driskull requested a review from a team as a code owner December 5, 2022 23:21
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 5, 2022
@driskull driskull changed the title fix(flow): Allow nested flow-items. fix(flow): Allow nested flows. Dec 5, 2022
@driskull
Copy link
Member Author

driskull commented Dec 5, 2022

@benelan Can you review this one?

@driskull driskull requested a review from benelan December 5, 2022 23:32
benelan
benelan approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@benelan benelan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an e2e test or story, unless I'm missing existing coverage for nested flows

@driskull driskull merged commit 214e3be into master Dec 6, 2022
@driskull driskull deleted the dris0000/flow-nested-fix branch December 6, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
Sprint 2022/12/04 - 2022/12/15
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@driskull @benelan