Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(block): Fix content spacing. #5898 #5918

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 6, 2022

fix(block): Fix content spacing. #5898

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 6, 2022
@driskull driskull marked this pull request as ready for review December 6, 2022 19:53
@driskull driskull requested a review from a team as a code owner December 6, 2022 19:53
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 6, 2022
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 6, 2022
@@ -142,6 +142,11 @@ calcite-handle {
grid-area: control;
}

.content--spaced {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a separate class here. we can use .content itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick ^

Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 6, 2022
@driskull driskull merged commit f32ddaa into master Dec 6, 2022
@driskull driskull deleted the dris0000/block-fix-padding branch December 6, 2022 21:22
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants