fix(modal, popover): Add disableFocusTrap property to toggle focus trapping.
#5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
changed the title
disableFocusTrap property should toggle focus trap.
…cite-components into dris0000/focus-trap-refactoring
driskull
changed the title
disableFocusTrap property should toggle focus trap.disableFocusTrap property to toggle focus trapping.
driskull
added
the
pr ready for visual snapshots
benelan
approved these changes
Dec 9, 2022
That was a different PR, but I think |
eriklharper
reviewed
Dec 9, 2022
|
Ah, I thought this PR was needed to disable the focus trap in Input to fix the crashing issue. Could modal/popover have a test that opens the component, tabs a full circle with focus trap on, turns focus trap off, and then tabs until it gets to an element outside of the modal/popover? |
benelan
added a commit
that referenced
this pull request
Dec 12, 2022
* master: (55 commits) build: update browserslist db (#5986) docs: update component READMEs (#5980) 1.0.0-next.670 refactor(input-date-picker,date-picker)!: Removing deprecated locale properties (#5977) 1.0.0-next.669 refactor(input-date-picker)!: Remove deprecated active property (#5974) 1.0.0-next.668 fix(modal, popover): Add `disableFocusTrap` property to toggle focus trapping. (#5965) 1.0.0-next.667 refactor(input-time-picker)!: Remove deprecated active property (#5970) docs(changelog): fix breaking change indent levels (#5973) 1.0.0-next.666 refactor(time-picker)!: Remove deprecated locale property (#5962) 1.0.0-next.665 fix(input, input-number, input-text): Fix infinite loop crashing browser. #5882 (#5961) test(floating-ui): fix type errors (#5966) docs: update component READMEs (#5964) 1.0.0-next.664 fix(alert): auto-dismissible retains close button and dismisses timer while a user is hovering over (#5872) chore(color-picker): add opacity string (#5959) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(modal, popover): Add
disableFocusTrapproperty to toggle focus trapping.