feat(input, input-number, input-text): add inputMode and enterKeyHint properties #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
approved these changes
Dec 9, 2022
| @@ -906,8 +925,8 @@ export class InputNumber | |||
| autofocus={this.autofocus ? true : null} | |||
| defaultValue={this.defaultValue} | |||
| disabled={this.disabled ? true : null} | |||
| enterKeyHint={this.el.enterKeyHint} | |||
| inputMode={this.el.inputMode} | |||
There was a problem hiding this comment.
nice. We shouldn't have these this.el props anymore :D
macandcheese
reviewed
Dec 9, 2022
| * Specifies the type of content to help devices display an appropriate virtual keyboard. | ||
| * Read the native attribute's documentation on MDN for more info. | ||
| * | ||
| * @mdn [step](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode) |
There was a problem hiding this comment.
Should we be passing this @mdn tag through to the documentation site UI at all to indicate these are native html attributes?
There was a problem hiding this comment.
Yeah that was my plan. I added all the tags but other stuff came up before I could get them thru docs-json. Probably a post v1 thing.
benelan
added
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5917
Summary
Adds
inputModeandenterKeyHintproperties toinput,input-text, andinput-number