Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popover/modal focus trap causes input elements not to get the focus set via mouse click #5993

Closed
AdelheidF opened this issue Dec 12, 2022 · 3 comments
Closed

popover/modal focus trap causes input elements not to get the focus set via mouse click #5993

AdelheidF opened this issue Dec 12, 2022 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
2023 January Prio...

Comments

@AdelheidF
Copy link

Actual Behavior

popover/modal focus trap causes input elements, inside or outside of popovers, not to get the focus when you click on them via mouse click.

E.g. a popover is open (focus trap set by default), now I can no longer edit an input box in a shell panel.

cc @driskull

Expected Behavior

A mouse click anywhere in the app should set the focus on that element. Focus trap set for an open popover should not affect this.

Reproduction Sample

https://codepen.io/afreitag/pen/XWzOjwK

Reproduction Steps

Try to edit value 0 in the panel

Reproduction Version

next.665

Relevant Info

No response

Regression?

No response

Impact

very high

Esri team

ArcGIS Map Viewer
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 12, 2022
@github-actions github-actions bot added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Dec 12, 2022
@driskull driskull mentioned this issue Dec 12, 2022
Merged
driskull added a commit that referenced this issue Dec 13, 2022
@driskull
fix(popover, modal): deactivate focus trap on outside click (#5994)
2a66134 
**Related Issue:** #5993

## Summary

fix(popover, modal): deactivate focus trap on outside click.

https://github.com/focus-trap/focus-trap/blob/master/README.md
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Dec 13, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@AdelheidF
Copy link
Author

AdelheidF commented Dec 13, 2022 •
edited

looks good in my various codepens with next.673, will test in map viewer later

@geospatialem geospatialem added this to the 2023 January Priorities milestone Dec 13, 2022
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed needs triage Planning workflow - pending design/dev review. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 13, 2022
@geospatialem
Copy link
Member

Verified in next.673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @AdelheidF