Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(split-button): no longer displays divider for transparent with inverse kind #6350

Merged
merged 2 commits into from Jan 27, 2023
Merged

fix(split-button): no longer displays divider for transparent with inverse kind #6350

merged 2 commits into from Jan 27, 2023

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Jan 25, 2023 •
edited

Related Issue: #6332

Summary

This PR will remove the divider background color when appearance="transparent" with kind="color"

Before the change:
1C7438FB-84F4-4C5C-9135-C0EE715C386E_4_5005_c

After the change:
A9BB5658-7012-44AA-B252-4ACF55E1FA74_4_5005_c

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 25, 2023
@anveshmekala anveshmekala marked this pull request as ready for review January 26, 2023 14:54
@anveshmekala anveshmekala requested a review from a team as a code owner January 26, 2023 14:54
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 26, 2023
@ashetland ashetland self-requested a review January 27, 2023 17:23
jcfranco
jcfranco approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@anveshmekala anveshmekala merged commit 11bc2e8 into master Jan 27, 2023
@anveshmekala anveshmekala deleted the anveshmekala/6332-fix-split-button-transparent-inverse branch January 27, 2023 21:32
@jcfranco jcfranco mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@ashetland ashetland ashetland approved these changes

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@anveshmekala anveshmekala

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2023 January Priorities Patch - Bugs ...
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anveshmekala @jcfranco @ashetland