fix(accordion): supports selection mode updates #6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
anveshmekala
added
the
pr ready for visual snapshots
| @@ -272,6 +271,7 @@ export class AccordionItem implements ConditionalSlotComponent { | |||
| //-------------------------------------------------------------------------- | |||
|
|
|||
| private determineActiveItem(): void { | |||
| this.selectionMode = getElementProp(this.el, "selection-mode", "multiple"); | |||
There was a problem hiding this comment.
Instead of checking here, could this be set by the parent Accordion when selectionMode is updated @Watch("selectionMode") ... ?
There was a problem hiding this comment.
i don't think that can be used here considering we are determining the selection of items inside the accordion-item.
jcfranco
approved these changes
Jan 28, 2023
| expect(element).toEqualAttribute("selection-mode", "single"); | ||
| element.setAttribute("selection-mode", "multiple"); | ||
| await page.waitForChanges(); | ||
| const item1 = await element.find("calcite-accordion-item[id='1']"); |
There was a problem hiding this comment.
Suggestion: const [item1, item2, item3] = await element.findAll("calcite-accordion-item");. Totally up to you. 😄
There was a problem hiding this comment.
Clean 🧹 . applied this to other tests too.
anveshmekala
added
pr ready for visual snapshots
anveshmekala
deleted the
anveshmekala/fix-accordion-dynamic-selection-mode-update
branch
github-actions
bot
added this to the 2023 February Priorities - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5143
Summary
This PR will allow user to switch
selection-modeand the items expand accordingly.