fix(alert): ensure border-radius is consistent for prescribed slots
#6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
approved these changes
Jan 27, 2023
| @@ -398,7 +398,7 @@ export class Alert implements OpenCloseComponent, LoadableComponent, T9nComponen | |||
| @State() queued = false; | |||
|
|
|||
| /** the close button element */ | |||
| private closeButton?: HTMLButtonElement; | |||
There was a problem hiding this comment.
This is fine for now, but for the future, let's keep these cleanup changes separate unless the code specific PR changes require a refactor or if it's in the modified line vicinity. Reasoning: there are no additional changes here that relevant to the PR.
|
@Elijbet I forgot to add, can you revisit the PR title to summarize the changes from a consumer perspective (i.e., what does this fix for users)? |
Elijbet
changed the title
border-radius
Elijbet
added
the
pr ready for visual snapshots
Elijbet
changed the title
border-radiusborder-radius was fixed
Elijbet
changed the title
border-radius was fixedborder-radius is consistent for prescribed slots
Elijbet
changed the title
border-radius is consistent for prescribed slotsborder-radius is consistent for prescribed slots
Elijbet
added
pr ready for visual snapshots
Elijbet
deleted the
elijbet/6348-alert-south-west-corner-radius-missing-when-icon-present
branch
github-actions
bot
added this to the 2023 February Priorities - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6348
Summary
The bottom left corner radius was missing when the icon was present. Upon inspection, it was clear that slots added around content don't have the proper radius set and end up covering the radius on the host. For each occasion the slot is placed against either end of the host, I adjusted the relevant radius to match the host container.
Because the close button is now always present, the cases addressed are the right side of the close button and the left side of the content (no icon) along with the left side of the icon (when placed in front of the content).
Added a screenshot for the radius with options where
iconis present and absent.