Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): prevent lines from expanded item from bleeding out of container #6372

Conversation

jcfranco
Copy link
Member

Related Issue: #6367

Summary

Restores styles needed to properly contain expanded item line that removed in #6005.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 28, 2023
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 28, 2023
@jcfranco jcfranco marked this pull request as ready for review January 28, 2023 04:52
@jcfranco jcfranco requested a review from a team as a code owner January 28, 2023 04:52
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 28, 2023
Copy link
Contributor

@Elijbet Elijbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫧✨ You're right. Looks like this bit did not need to get removed in the previous fix. 🫧✨

@jcfranco jcfranco merged commit d2fa8a6 into master Jan 30, 2023
@jcfranco jcfranco deleted the jcfranco/6367-prevent-expanded-item-lines-from-bleeding-out-of-container branch January 30, 2023 19:00
Copy link
Contributor

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants