fix(value-list): add back instructions for screen reader when drag handle is activated #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle is activated
github-actions
bot
added
the
bug
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
anveshmekala
added
a11y
anveshmekala
added
pr ready for visual snapshots
jcfranco
approved these changes
Feb 23, 2023
| * @internal | ||
| */ | ||
| @Event({ cancelable: true }) | ||
| calciteValueListItemDragHandleBlur: EventEmitter<ListItemAndHandle>; |
There was a problem hiding this comment.
Is it possible to use the getHandleAndItemElement util to avoid passing the item and handle here?
There was a problem hiding this comment.
i tried doing so but the focusEvent doesn't show up the handle element in either composedPath or event.target
| @@ -457,6 +458,14 @@ export class ValueList< | |||
| } | |||
| }; | |||
|
|
|||
| @Listen("calciteValueListItemDragHandleBlur") | |||
There was a problem hiding this comment.
I think this can be achieved by using focusout, but let's proceed with this for now and please open a follow-up issue to revisit this approach.
There was a problem hiding this comment.
Added a follow-up issue #6526
anveshmekala
added
pr ready for visual snapshots
github-actions
bot
added this to the 2023 February Priorities - 1.1.0 - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6401
Summary
This PR will add back instructions for screen reader when drag handle is activated via
Spacekey.Sidebar: This will also cover #5739