Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree item content now clipped if wrapping beyond two lines #6514

Closed
nwhittaker opened this issue Feb 23, 2023 · 3 comments
Closed

Tree item content now clipped if wrapping beyond two lines #6514

nwhittaker opened this issue Feb 23, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 February Pri...

Comments

@nwhittaker
Copy link
Contributor

Actual Behavior

Tree item clips content:

Screenshot 2023-02-23 at 1 17 45 PM

Expected Behavior

Tree item hugs content:

Screenshot 2023-02-23 at 1 17 28 PM

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/rNZeXVq

Reproduction Steps

  1. See sample

Reproduction Version

1.0.7

Relevant Info

Somewhat related to #6512

Regression?

1.0.5

Impact

The Field Maps web app uses the tree element to organize layers and nested layers. The tree-item content is the layer's name -- as such it is not impossible to imagine users who have constructed long layer names.

The tree also exists within a resizable panel -- so even short layer names could wrap.

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 23, 2023
@github-actions github-actions bot added the ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. label Feb 23, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 24, 2023
@geospatialem geospatialem mentioned this issue Feb 24, 2023
Closed
@jcfranco jcfranco self-assigned this Feb 24, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. and removed 0 - new New issues that need assignment. labels Feb 24, 2023
@jcfranco jcfranco mentioned this issue Feb 24, 2023
Merged
@alisonailea alisonailea assigned jcfranco and unassigned jcfranco Feb 28, 2023
jcfranco added a commit that referenced this issue Feb 28, 2023
@jcfranco
fix(tree): prevent tree-item content from being clipped (#6519)
8501b23 
**Related Issue:** #6514 

## Summary

This drops any clipping and also ensures the min-height of tree-items
adheres to the design spec while still allowing items to grow if needed
to accommodate their content.

cc @SkyeSeitz @ashetland
@jcfranco
Copy link
Member

Installed.

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 28, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Feb 28, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 1, 2023
@geospatialem
Copy link
Member

Verified in 1.0.8-next.3

image

@jcfranco jcfranco mentioned this issue Mar 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 February Priorities Patch (1.0.8...
Development

No branches or pull requests
4 participants
@jcfranco @nwhittaker @alisonailea @geospatialem