fix(block): Corrects alignment of slotted icon #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
macandcheese
added
the
pr ready for visual snapshots
jcfranco
approved these changes
Apr 28, 2023
| @@ -43,7 +43,7 @@ | |||
| <div class="child right-aligned-text">default (non-collapsible + no block-section)</div> | |||
|
|
|||
| <div class="child"> | |||
| <calcite-block heading="Fruit" summary="It's nature's candy"> </calcite-block> | |||
| <calcite-block heading="Fruit" description="It's nature's candy"> </calcite-block> | |||
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6627
Summary
Adjust slotted icon container css to better align the icon container. Small misalignments due to icon may still occur but this should be better than before. Adds a handful of test-only stories to capture more Block states, and fixes some instance of an outdated prop used in demo pages.
cc @ashetland @SkyeSeitz - I think this was already correct in Figma, but FYI as this will likely require Chromatic approval.
cc @asangma @mitc7862 - FYI
Before:
After:
