Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): adds calciteListChange event to get selectedItems. #6894

Merged
merged 6 commits into from May 2, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented May 2, 2023

Related Issue: #6362

Summary

  • Adds event calciteListChange
  • calciteListChange can be used to listen for selection changes and access the selectedItems property.
  • This event is necessary because we listen for the calciteListItemSelect and then debounce before setting the selectedItems property.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label May 2, 2023
@driskull driskull marked this pull request as ready for review May 2, 2023 15:53
@driskull driskull requested a review from a team as a code owner May 2, 2023 15:53
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝
📝📝☑☑☑📝📝☑☑📝📝📝☑☑📝📝☑📝📝📝☑📝
📝☑📝📝📝📝☑📝📝☑📝☑📝📝☑📝☑📝📝📝☑📝
📝☑📝📝📝📝☑📝📝☑📝☑📝📝☑📝☑📝📝📝☑📝
📝☑📝📝📝📝☑📝📝☑📝☑📝📝☑📝☑📝📝📝📝📝
📝📝☑☑☑📝📝☑☑📝📝📝☑☑📝📝☑☑☑📝☑📝
📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝📝

src/demos/list.html Outdated Show resolved Hide resolved
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 2, 2023
@driskull driskull merged commit 37959ce into master May 2, 2023
14 checks passed
@driskull driskull deleted the dris0000/list-event-updates branch May 2, 2023 19:50
@github-actions github-actions bot added this to the 2023 May Priorities milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants