fix(tree): allow selection of parent category w/out selecting children

[paulcpederson]

Related Issue: #6912, #6444, #6509

Summary

Updates the interaction model of trees to adhere to the new design. The key changes to the interaction model are:

1. Tree items will expand when they are clicked (Tree component parents will not open or close when user clicks on parent name #6444)
2. Child selection modes will not automatically display all children of a selected item as selected (Calcite tree - allow selection of parent category w/out selecting children #6912)
3. Clicking a slotted action inside a tree item will not select the tree item (Clicking tree item action also selects it #6509)

Note: this pr does not address the hover states in that design. We are coming down to the wire and I want to give time for code review. I can help address the styling/focus/hover/accessibility aspects of the tree next release.

[driskull]

Looks good to me! Just had some feedback on filtering out specific elements from the onclick handler.

[paulcpederson]

Running the e2e again as they somehow started failing? Is this normal?

[driskull]

👍 ✨

[paulcpederson]

@driskull or @jcfranco do you have any ideas on the e2e tests? Seeing it locally too. I went back to the commit that passed and it also failed, so wondering what could have changed?

Error: Protocol error (Runtime.callFunctionOn): Session closed. Most likely the page has been closed.

hmmm, the actions runner reports a tooltip test failing.

[jcfranco]

↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖
↖🌳↖↖↖🌳↖🌳🌳🌳↖↖🌳🌳🌳↖🌳🌳🌳🌳↖🌳↖
↖🌳🌳↖↖🌳↖↖🌳↖↖🌳↖↖↖↖🌳↖↖↖↖🌳↖
↖🌳↖🌳↖🌳↖↖🌳↖↖🌳↖↖↖↖🌳🌳🌳↖↖🌳↖
↖🌳↖↖🌳🌳↖↖🌳↖↖🌳↖↖↖↖🌳↖↖↖↖↖↖
↖🌳↖↖↖🌳↖🌳🌳🌳↖↖🌳🌳🌳↖🌳🌳🌳🌳↖🌳↖
↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖↖

I'll take a look at the unstable test. 👀

[jcfranco]

I think this comment can be dropped as the line below is expressive enough.

[jcfranco]

I'll take a look at the unstable test. 👀

Talked to @driskull and I think found a way to stabilize the tooltip tests. Feel free to skip them (https://github.com/Esri/calcite-components/blob/master/src/components/tooltip/tooltip.e2e.ts#L730 and https://github.com/Esri/calcite-components/blob/master/src/components/tooltip/tooltip.e2e.ts#L791) to get this installed and I'll submit a separate PR for restoring/stabilizing the skipped tests.

[paulcpederson]

I skipped the tests and addressed the pr comment, will see how the e2e tests go

[jcfranco]

Thanks again, @paulcpederson! Can you open a follow-up issue for the pending styling/focus/hover/accessibility updates?

[geospatialem]

Added a follow-up issue targeted for August regarding the hover states in #6930.

@paulcpederson were there other considerations with styling, focus or a11y for another follow-up issue? Didn't see other context in Figma or the linked issues.

[paulcpederson]

Nope, the styling was left as is for now. I think your hover states issue should cover updating that. Accessibility has it's own issue IIRC. Nothing more to open for this, thanks for opening that issue. And thanks @jcfranco for the merge