Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-date-picker): update input-date-picker to properly handle Buddhist calendar changes #6970

Merged
merged 1 commit into from May 17, 2023
Merged

fix(input-date-picker): update input-date-picker to properly handle Buddhist calendar changes #6970

merged 1 commit into from May 17, 2023

Conversation

jcfranco
Copy link
Member

Related Issue: #6636

Summary

This updates input-date-picker to follow date-picker's logic and map between the internal and displayed date values for Buddhist calendars.

@jcfranco jcfranco requested a review from a team as a code owner May 16, 2023 22:43
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 16, 2023
driskull
driskull approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 17, 2023
@jcfranco jcfranco merged commit 1d8ad68 into master May 17, 2023
11 of 12 checks passed
@jcfranco jcfranco deleted the jcfranco/6636-parse-and-display-year-properly-for-th-locale branch May 17, 2023 16:37
@github-actions github-actions bot added this to the 2023 May Priorities milestone May 17, 2023
Elijbet pushed a commit that referenced this pull request May 17, 2023
@jcfranco @Elijbet
fix(input-date-picker): update input-date-picker to properly handle B…
2dd39bd 
…uddhist calendar changes (#6970)

**Related Issue:** #6636

## Summary

This updates `input-date-picker` to follow `date-picker`'s logic and map
between the internal and displayed date values for Buddhist calendars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2023 May Priorities
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcfranco @driskull