fix(time-picker): prevent time-picker part steppers from being focusable #6982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
changed the title
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/6851-prevent-time-part-steppers-from-receiving-focus
branch
|
Many thanks for fixing this! I started noticing that as a result of the focus trap changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6851
Summary
This ensures the hour, minute and second inputs are the only focusable elements within the component. Previously, focus would land on the hour-increment stepper (due to
tabIndex=1on steppers and the component usingdelegatesFocus: true), which doesn't listen to up/down keys.