Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Shell / Shell Panel - content-behind should allow both fixed and detached shell-panels #1932

Open
4 tasks
macandcheese opened this issue Apr 8, 2021 · 4 comments
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Apr 8, 2021

Description

Consider the following app layout:

Screen Shot 2021-04-08 at 7 47 12 AM

In the above, content-behind is used on calcite-shell. However, I need to manually add padding to the map container to account for the left-hand shell-panel's width. What I want is the right shell-panel to display as "detached", and the left shell-panel to display as "normal", but the center-panel content to render to the right of the left shell-panel, not behind it.

If I don't manually add that padding, the map renders "behind" the fixed left-hand shell-panel:

Screen Shot 2021-04-08 at 7 52 47 AM

In addition, slots should be added to position content, such as "content-start"/"content-end".

Acceptance Criteria

Relevant Info

Which Component

Example Use Case

@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. labels Apr 8, 2021
@benelan benelan added the needs triage Planning workflow - pending design/dev review. label Sep 27, 2021
@jcfranco
Copy link
Member

Please add your planning poker estimate with ZenHub @macandcheese

@macandcheese
Copy link
Contributor Author

@jcfranco did initial estimate but need input from @asangma

@geospatialem
Copy link
Member

This came up via a user on Community where they would like to use the features widget in one panel, and a layer list on the other side of the UI.

There is a workaround, where the Maps SDK for JS view UI can be added, such as:

view.ui.add("customEl", "top-right");

Here's a sample for additional context: https://codepen.io/geospatialem/pen/oNQyaPM

Escalating the request as it should be a supported workflow in the future, potentially also removing the content-behind prop on calcite-shell. cc @macandcheese

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jul 21, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Jul 26, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@geospatialem geospatialem added the estimate - 8 Requires input from team, consider smaller steps. label Jan 24, 2024
@geospatialem
Copy link
Member

Additional use case from #5668 is listed below from @bluespider42.

Also added the acceptance criteria to include context from #5668 and #7199 for consideration prior to closing out the related issues.

Include the ability to have a panel alligned with the bottom of the screen inside a shell-panel. This could be done to match the action-bar, which has a "bottom-actions" slot. So a shell-panel could have a "bottom-panels" slot or similar.

But with the action-bar you can have the action at the bottom of the action-bar, as a user I would expect this to open the panel at the bottom left-hand corner.:
panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

5 participants