Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calcite tabs interfering with other calcite elements``` #6359

Closed
sam11927 opened this issue Jan 26, 2023 · 6 comments
Closed

Calcite tabs interfering with other calcite elements``` #6359

sam11927 opened this issue Jan 26, 2023 · 6 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. needs triage Planning workflow - pending design/dev review.

Comments

@sam11927
Copy link

sam11927 commented Jan 26, 2023

Actual Behavior

We have a set of calcite tabs and one of the tabs contains an accordion with expanded set to true on the initial render, however, sometimes when opening the tabs in a calcite-panel, the expand/collapse button on the accordion does not work and an error is seen in the console.

Expected Behavior

Expandable button should work on accordion within a tab within a panel/shell

Reproduction Sample

NA

Reproduction Steps

  1. have a shell
  2. have tabs inside the shell
  3. have accordion inside a tab
  4. open the shell
  5. notice expand button does not work and console error is seen
    (had some issues reproducing in a codepen, feel free to reach out to me and I can provide more info if this is not sufficient)

Reproduction Version

next

Relevant Info

constructor(e) {
        t(this, e),
        this.calciteTabChange = i(this, "calciteTabChange", 6),
        this.calciteInternalTabChange = i(this, "calciteInternalTabChange", 6),
        this.animationActiveDuration = .3,
        this.resizeObserver = b("resize", (()=>{
            this.activeIndicatorEl.style.transitionDuration = "0s",
            this.updateActiveWidth(),
            this.updateOffsetPosition()
        }

TypeError: Cannot read properties of undefined (reading 'style')
activeIndicatorEl is undefined I think

Regression?

No response

Impact

This is part of our apps core workflow

Esri team

ArcGIS Online

@sam11927 sam11927 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 26, 2023
@github-actions github-actions bot added the ArcGIS Online Issues logged by ArcGIS Online team members. label Jan 26, 2023
@github-actions
Copy link
Contributor

It looks like this issue is missing some information:

  • A codepen, codesandbox, or jsbin that reproduces the issue. Alternatively, a documentation sample can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.

Issues without reproduction samples may not be prioritized. If you were unable to create a sample, please try to answer any questions that arise once development begins. Thanks for your understanding.

@github-actions github-actions bot added the incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. label Jan 26, 2023
@macandcheese
Copy link
Contributor

Related - #6310

@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jan 31, 2023
@geospatialem
Copy link
Member

geospatialem commented Jan 31, 2023

@sam11927 We had a fix for the 6310 issue Adam referenced above in 1.0.4-next.4. Can you verify if the fix applies to the use case mentioned above?

@github-actions
Copy link
Contributor

Installed and assigned for verification.

@ethanbdev ethanbdev added ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members and removed ArcGIS Online Issues logged by ArcGIS Online team members. labels Feb 1, 2023
@sam11927
Copy link
Author

sam11927 commented Feb 1, 2023

@sam11927 We had a fix for the 6310 issue Adam referenced above in 1.0.4-next.4. Can you verify if the fix applies to the use case mentioned above?

Yep looks good on that version

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 1, 2023
@geospatialem
Copy link
Member

Awesome, thanks for verifying! Will close out the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

4 participants