Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notice] Responsive layout #6779

Closed
6 tasks
geospatialem opened this issue Apr 13, 2023 · 10 comments
Closed
6 tasks

[Notice] Responsive layout #6779

geospatialem opened this issue Apr 13, 2023 · 10 comments
Assignees
Labels
2 - in development Issues that are actively being worked on. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.

Comments

@geospatialem
Copy link
Member

Description

Mobile responsiveness across Calcite Design System, focused on web (traditionally desktop sized web browser), tablet, phone screen sizes, and large monitors.

Acceptance Criteria

  • 1. Consider breaking changes for folks. Consultation should occur on both the design and development teams.
  • 2. Components need to be designed for the following breakpoints:
    • Small (s), 476px
    • Medium (m), 768px
    • Large (l), 1152px
    • Extra larger (xl), 1440px

Relevant Info

Part of epic #6670

Which Component

notice

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

Calcite (design)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Apr 13, 2023
@SkyeSeitz
Copy link

Thanks, @geospatialem !

@SkyeSeitz
Copy link

@manuelalcosta presented iterations for Notice on smaller screen sizes and mobile devices. Below is the solution we landed on, where the icon moves above the Notice text and the actions-end moves to the bottom, right aligned. 

image

@SkyeSeitz SkyeSeitz self-assigned this Apr 14, 2023
@SkyeSeitz
Copy link

Since Notice and Alert will share a very similar responsive layout solution, the Notice design proposal is on hold until Alert is finalized.

@geospatialem geospatialem added the blocked This issue is blocked by another issue. label May 11, 2023
@ashetland ashetland added this to the Design Sprint Planning milestone May 30, 2023
@ashetland ashetland removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 30, 2023
@SkyeSeitz
Copy link

SkyeSeitz commented Jul 18, 2023

Final specs available here

@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Jul 18, 2023
@SkyeSeitz SkyeSeitz removed their assignment Jul 18, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 18, 2023
@github-actions github-actions bot removed this from the Design Backlog milestone Jul 18, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem removed blocked This issue is blocked by another issue. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jul 21, 2023
@geospatialem geospatialem added this to the 2023 August Priorities milestone Jul 26, 2023
@jcfranco jcfranco self-assigned this Sep 1, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 1, 2023
@jcfranco jcfranco removed the 1 - assigned Issues that are assigned to a sprint and a team member. label Sep 8, 2023
@jcfranco jcfranco added the 2 - in development Issues that are actively being worked on. label Sep 8, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit label Sep 12, 2023
@jcfranco
Copy link
Member

@SkyeSeitz @ashetland Per our conversation, responsive notice will be put on hold since it would be too disruptive in the current layouts its used in. LMK if I missed something or need to make corrections.

@SkyeSeitz
Copy link

Thanks, Franco. Since typical usage of Notice at narrow widths, e.g. within calcite-panel, work better with an inline icon & actions, my gut is to close this issue out and re-open in the future if a need arises.

@geospatialem

@ashetland
Copy link

Agreed.

@geospatialem
Copy link
Member Author

Per the above discussion, is there a good summary we can provide folks that encounter narrower widths, but also to support wider ones as well?

Once we have a comprehensive solution for folks, think we can close the above issue out. cc @SkyeSeitz @ashetland @jcfranco

@geospatialem
Copy link
Member Author

Updating notice to change at small widths would be too disruptive as it's a pretty common use case for the component. Calcite team members will revisit if there's an increased demand or ask in the future. Closing as not planned for the time being.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - in development Issues that are actively being worked on. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

5 participants