Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input, Input Message - Provide valid, concise, and meaningful alternative text for image buttons - (2036569942) #7793

Closed
dqateam opened this issue Sep 19, 2023 · 2 comments
Labels
a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Provide valid, concise, and meaningful alternative text for image buttons

WCAG Reference:

Severity:

6

Media Type:

Forms


Areas for Remediation:

  • Title: Input, Input Message - Provide valid, concise, and meaningful alternative text for image buttons - (2036569942)

  • Module: Input, Input Message
    Issue
    There are image buttons present besides the below mentioned input fields that do not provide an accessible name. Examples include:

  • Vertical:

  • Vertical with Prefix and Suffix text:

  • Horizontal:

  • Horizontal with Prefix and Suffix text:

  • Number input error message

User Impact
Without meaningful alternative text, any information conveyed by these image buttons will not be conveyed to screen reader users and they will be announced as unlabeled buttons.

Code Reference

<button class="number-button-item" data-adjustment="up" tabindex="-1" type="button"><calcite-icon aria-hidden="true" icon="chevron-up" scale="s" calcite-hydrated=""></calcite-icon></button>

Suggestion
Ensure that image buttons provide meaningful alternative text. This can be achieved by providing any of the following:- an alt attribute for input type image

  • an aria-label for nested icon font elements
  • an alt attribute for nested <img> elements
  • a referenced <title> element for svg images (the svg element should provide an aria-labelledby attribute that maps to the id attribute value of the nested title)

Compliant Code Example

<button class="number-button-item" data-adjustment="up" aria-label="increase number" type="button"><calcite-icon aria-hidden="true" icon="chevron-up" scale="s" calcite-hydrated=""></calcite-icon></button>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@driskull driskull added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Nov 7, 2023
@driskull
Copy link
Member

driskull commented Nov 7, 2023

Seems like a pretty easy issue to address. The number increment/decrement buttons just need an aria-label set from messages.

@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 7, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 7, 2023
@macandcheese
Copy link
Contributor

macandcheese commented Jan 29, 2024

I don't think this needs to be addressed since these are non-focusable elements that replicate the native "in-field" spinners. Similar to our in-field clear button implementation. Closing as a result cc @geospatialem

@macandcheese macandcheese removed the 0 - new New issues that need assignment. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

4 participants