Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell and Shell Panel - Ensure implicit list markup is avoided - (2036570580) #7827

Closed
Tracked by #7851
dqateam opened this issue Sep 19, 2023 · 2 comments
Closed
Tracked by #7851
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure implicit list markup is avoided
image

WCAG Reference:

Severity:

6

Media Type:

Lists


Areas for Remediation:

  • Title: Shell and Shell Panel - Ensure implicit list markup is avoided - (2036570580)
  • Module: Shell and Shell Panel
    Pattern: List- Missing list markup.]

Issue
There is content that appears as a list but does not use list markup. Examples include:

  • Add action, for display purposes only
  • Layers action, for display purposes only, etc content in the left and right side panel.
  • A filter-enabled value list for the item.

Occurrences
29 Shell and Shell Panel
30 Shell Center Row

User Impact
Screen reader users will have difficulty understanding that this content is a list.

Code Reference

<button aria-busy="false" aria-disabled="false" aria-label="Add action, for display purposes only" class="button button--text-visible"><div aria-hidden="true" class="icon-container"><calcite-icon aria-hidden="true" icon="plus" scale="s" calcite-hydrated=""></calcite-icon><div class="slot-container"><slot></slot></div></div><div class="text-container text-container--visible">Add action</div></button>
(...)
<button aria-busy="false" aria-disabled="false" aria-label="Collapse" class="button button--text-visible">...
</button>

Suggestion
Ensure implicit list markup is avoided. Lists must use <ul>, <ol>, <li>, <dl>, <dt>, and <dd> elements as appropriate.

Compliant Code Example

<ul>
<li><button aria-busy="false" aria-disabled="false" aria-label="Add action, for display purposes only" class="button button--text-visible"><div aria-hidden="true" class="icon-container"><calcite-icon aria-hidden="true" icon="plus" scale="s" calcite-hydrated=""></calcite-icon><div class="slot-container"><slot></slot></div></div><div class="text-container text-container--visible">Add action</div></button></li>
(...)
<li><button aria-busy="false" aria-disabled="false" aria-label="Collapse" class="button button--text-visible">...
</button></li>
</ul>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@macandcheese
Copy link
Contributor

This seems unrelated to Shell or Shell Panel - referenced code is not part of these components. Could we close this one?

@geospatialem
Copy link
Member

Closing, looks like a false positive due to testing.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants