Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree and Tree Item - Ensure ARIA roles, states, and properties are valid - (2036570419) #7846

Closed
dqateam opened this issue Sep 19, 2023 · 1 comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure ARIA roles, states, and properties are valid

image

WCAG Reference:

Severity:

5

Media Type:

ARIA


Areas for Remediation:

  • Title: Tree and Tree Item - Ensure ARIA roles, states, and properties are valid - (2036570419)

  • Module: Tree and Tree Item
    Issue
    There are elements with invalid ARIA role treeitem. Examples include:

  • Child 1

  • Child 2

  • Child 3

  • Grandchild 1

  • Grandchild 2, etc.

User Impact
Assistive technologies may be unable to parse this content.

Code Reference

<div aria-hidden="false" role="treeitem" tabindex="0" depth="1" scale="s" calcite-hydrated=""><div class="node-container" data-selection-mode="single"><div class="bullet-point" aria-hidden="true" icon="bullet-point" scale="s" calcite-hydrated=""><svg class="svg" fill="currentColor" height="100%" viewbox="0 0 16 16" width="100%" xmlns="http://www.w3.org/2000/svg"><path d="M8 6a2 2 0 1 0 0 4 2 2 0 1 0 0-4z"></path></svg></div>Child 1</div><div class="children-container" data-test-id="calcite-tree-children"></div></div>

Suggestion
Ensure ARIA roles, states, and properties are valid. Many ARIA attributes can only be used on certain elements. Some can only be used in combination with other attributes. Additionally, if an attribute references an ID, that ID must be present in the page.

To detect many of these errors automatically, use the Nu Html Checker: https://validator.w3.org/nu/

Compliant Code Example

<button aria-pressed="false">Child 1</button>
(...)
<button aria-expanded="false">Child 2</button>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@geospatialem
Copy link
Member

This seems like an invalid issue due to testing, closing per internal discussions on the component's role and state. We can reopen if others identify an issue.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants