Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcite-color-picker: should be responsive to container sizes #8463

Open
2 of 6 tasks
AdelheidF opened this issue Dec 20, 2023 · 2 comments
Open
2 of 6 tasks

calcite-color-picker: should be responsive to container sizes #8463

AdelheidF opened this issue Dec 20, 2023 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - design - sm Small design effort; 1-4 days of design work impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@AdelheidF
Copy link

AdelheidF commented Dec 20, 2023

Check existing issues

Actual Behavior

If color-picker is inside a panel that scrolls vertically then horizontal scrollbars appear in FF. Chrome is fine.

If you set display:flex on the color-picker and overflow:hidden on its container inside the shadow-dom then it's correct.

cc @driskull

Expected Behavior

No horizontal scroll bars in any browser.

Reproduction Sample

https://codepen.io/afreitag/pen/KKYgKzW
https://codepen.io/afreitag/pen/OJqLWEB

Reproduction Steps

Open codepen in Chrome and Firefox. You'll see horizontal scrollbars in FF.

Reproduction Version

2.1.0

Relevant Info

Firefox

Regression?

no

Priority impact

p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer

@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 20, 2023
@github-actions github-actions bot added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. labels Dec 20, 2023
@driskull
Copy link
Member

note: Seems like the color-picker component should be more flexible in its sizing. It should respond to its container and not overflow its boundaries.

@geospatialem geospatialem added the design-tokens Issues requiring design tokens. label Dec 21, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Jan 11, 2024
@geospatialem
Copy link
Member

Design expertise sought on the color controls for the container sizing and/if design tokens could mitigate.

@brittneytewks brittneytewks added p - medium Issue is non core or affecting less that 60% of people using the library estimate - design - sm Small design effort; 1-4 days of design work and removed needs triage Planning workflow - pending design/dev review. labels Mar 4, 2024
@brittneytewks brittneytewks added this to the Design Backlog milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - design - sm Small design effort; 1-4 days of design work impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants