Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input + Text Area: Add native spellcheck prop #9148

Open
2 of 9 tasks
geospatialem opened this issue Apr 18, 2024 · 1 comment
Open
2 of 9 tasks

Input + Text Area: Add native spellcheck prop #9148

geospatialem opened this issue Apr 18, 2024 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. p4 - not time sensitive User set priority status of p4 - not time sensitive

Comments

@geospatialem
Copy link
Member

Check existing issues

Description

Add spellcheck prop to Text Area + Input with a note like this in the doc: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck#security_and_privacy_concerns

Acceptance Criteria

Relevant Info

Requested via ArcGIS resources feedback:

CalciteInputText is missing the property "spellcheck" from the native input-text HTML component! There are instances when the input component do not have to contain dictionary-words (as peculiar street names) and we do not want weird words to be underlined!

Which Component

  • text-area
  • input

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 18, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. p4 - not time sensitive User set priority status of p4 - not time sensitive labels Apr 18, 2024
@Horiatu
Copy link

Horiatu commented Apr 18, 2024

Just a suggestion: name the attribute nospellcheck so the current code will behave the same with new and old version of components without amending every instance in written code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. p4 - not time sensitive User set priority status of p4 - not time sensitive
Projects
None yet
Development

No branches or pull requests

2 participants