refactor: add simpler componentFocusable util (deprecates LoadableComponent) #9362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
jcfranco
added
the
pr ready for visual snapshots
jcfranco
added a commit
that referenced
this pull request
Jun 8, 2024
…LoadableComponent`) (#9515) **Related Issue:** N/A ## Summary #9362 introduced a utility that aimed to simplify how components wait to be loaded/ready before certain logic. Unfortunately, the behavior differs between `dist` and `components` output targets. This is because the utility assumes components from the `components` output target are not returning promises in lifecycle hooks that would delay initial rendering. See ionic-team/stencil-site#1437 for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Adds a replacement
componentFocusableutil that does not depend on implementingLoadableComponent.