Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-date-picker, date-picker): ensure day selection doesn't activate the previous day in certain scenarios #9424

Merged
merged 18 commits into from
Jun 10, 2024
Merged

fix(input-date-picker, date-picker): ensure day selection doesn't activate the previous day in certain scenarios #9424

merged 18 commits into from
Jun 10, 2024

Conversation

eriklharper
Copy link
Contributor

Related Issue: #9422

Summary

This fixes an issue where in some cases selecting a date in the date-picker popup of input-date-picker would select the previous day instead of the one selected.

@eriklharper eriklharper requested a review from a team as a code owner May 24, 2024 23:44
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 24, 2024
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 28, 2024
@eriklharper eriklharper changed the title fix(input-date-picker): selecting day no longer activates previous day fix(input-date-picker): selecting day doesn't activates previous day in certain scenarios May 28, 2024
anveshmekala
anveshmekala approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 29, 2024
@eriklharper eriklharper changed the title fix(input-date-picker): selecting day doesn't activates previous day in certain scenarios fix(input-date-picker): ensure day selection doesn't activate the previous day in certain scenarios May 30, 2024
@eriklharper eriklharper changed the title fix(input-date-picker): ensure day selection doesn't activate the previous day in certain scenarios fix(date-picker): ensure day selection doesn't activate the previous day in certain scenarios May 30, 2024
jcfranco
jcfranco requested changes May 30, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

packages/calcite-components/src/utils/date.ts Show resolved Hide resolved
packages/calcite-components/src/utils/date.ts Show resolved Hide resolved
@eriklharper eriklharper requested a review from jcfranco June 5, 2024 19:11
@eriklharper eriklharper removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 5, 2024
jcfranco
jcfranco approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓
🗓📆🗓🗓🗓📆🗓🗓📆📆🗓🗓📆📆📆🗓🗓📆📆📆🗓📆📆📆📆🗓📆🗓
🗓📆📆🗓🗓📆🗓📆🗓🗓📆🗓🗓📆🗓🗓📆🗓🗓🗓🗓📆🗓🗓🗓🗓📆🗓
🗓📆🗓📆🗓📆🗓📆🗓🗓📆🗓🗓📆🗓🗓📆🗓🗓🗓🗓📆📆📆🗓🗓📆🗓
🗓📆🗓🗓📆📆🗓📆🗓🗓📆🗓🗓📆🗓🗓📆🗓🗓🗓🗓📆🗓🗓🗓🗓🗓🗓
🗓📆🗓🗓🗓📆🗓🗓📆📆🗓🗓📆📆📆🗓🗓📆📆📆🗓📆📆📆📆🗓📆🗓
🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓🗓

packages/calcite-components/src/components/date-picker/date-picker.e2e.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/components/date-picker/date-picker.e2e.ts Outdated Show resolved Hide resolved
@jcfranco
Copy link
Member

jcfranco commented Jun 7, 2024

Should the PR also include input-date-picker in the scope?

@eriklharper
grouping tests into a describe block
71c9ede
@eriklharper
Merge branch 'eriklharper/9422-previous-day-selected-input-date-picke…
e6c7b04 
…r' of github.com:Esri/calcite-design-system into eriklharper/9422-previous-day-selected-input-date-picker
@eriklharper
DRYing up the century tests
dce8d4f
@eriklharper eriklharper changed the title fix(date-picker): ensure day selection doesn't activate the previous day in certain scenarios fix(input-date-picker, date-picker): ensure day selection doesn't activate the previous day in certain scenarios Jun 7, 2024
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 7, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:12
@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 10, 2024
@eriklharper eriklharper merged commit ab77212 into dev Jun 10, 2024
12 checks passed
@eriklharper eriklharper deleted the eriklharper/9422-previous-day-selected-input-date-picker branch June 10, 2024 22:21
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@alisonailea alisonailea alisonailea approved these changes

@anveshmekala anveshmekala anveshmekala approved these changes

Assignees

@eriklharper eriklharper

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eriklharper @jcfranco @alisonailea @anveshmekala