fix(panel): prevent menu actions from being clipped in Safari #9488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
geospatialem
reviewed
Jun 3, 2024
There was a problem hiding this comment.
@geospatialem @DitwanP could one of you help test this fix?
The fix works across Windows browsers for Chrome, Firefox, and Edge -- while also allowing scrolling. 🙌🏻
cc: @DitwanP for Safari testing.
Looks good to me 👍 |
driskull
changed the title
driskull
changed the title
driskull
added
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8028
Summary
position:relativeon the container class within the panel seems to fix the safari issue. Not sure how we can test this without manual testing or getting different browser screenshots setup.@geospatialem @DitwanP could one of you help test this fix?