Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-date-picker, input-time-picker): focus input element on setFocus #9584

Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix(input-date-picker, input-time-picker): focus input element on setFocus #9584

merged 4 commits into from
Jun 17, 2024

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Jun 14, 2024 •
edited
Loading

Related Issue: #9491

Summary

Focuses input element on setFocus method.

@anveshmekala anveshmekala requested a review from a team as a code owner June 14, 2024 03:42
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 14, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 14, 2024
@anveshmekala anveshmekala marked this pull request as draft June 14, 2024 16:46
jcfranco
jcfranco reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

Can you also update the E2E tests to use the focusable test helper?

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 14, 2024
@anveshmekala anveshmekala marked this pull request as ready for review June 14, 2024 23:13
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jun 14, 2024
jcfranco
jcfranco approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅
📅⌚📅📅📅⌚⌚⌚⌚📅⌚⌚⌚⌚⌚📅⌚📅📅📅⌚📅⌚📅
📅⌚📅📅📅⌚📅📅📅📅📅📅⌚📅📅📅⌚⌚📅⌚⌚📅⌚📅
📅⌚📅📅📅⌚📅⌚⌚📅📅📅⌚📅📅📅⌚📅⌚📅⌚📅⌚📅
📅⌚📅📅📅⌚📅📅⌚📅📅📅⌚📅📅📅⌚📅📅📅⌚📅📅📅
📅⌚⌚⌚📅⌚⌚⌚⌚📅📅📅⌚📅📅📅⌚📅📅📅⌚📅⌚📅
📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅📅

@jcfranco jcfranco changed the title fix(input-date-picker,input-time-picker): focuses input element on setFocus fix(input-date-picker,input-time-picker): focus input element on setFocus Jun 17, 2024
@jcfranco jcfranco changed the title fix(input-date-picker,input-time-picker): focus input element on setFocus fix(input-date-picker, input-time-picker): focus input element on setFocus Jun 17, 2024
@anveshmekala anveshmekala merged commit c7b8a68 into dev Jun 17, 2024
14 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/fix-setFocus-date-picker-and-time-picker branch June 17, 2024 22:21
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@anveshmekala anveshmekala

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anveshmekala @jcfranco