Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): Prevent unexpected keyboard autoplay activation #9621

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

macandcheese
Copy link
Contributor

Related Issue: #9620

Summary

Adds a check for autoplay in our keyboard interaction handler. Adds a test to confirm behavior.

@macandcheese macandcheese requested a review from a team as a code owner June 17, 2024 22:08
@macandcheese macandcheese added this to the 2024-06-25 - Jun Release milestone Jun 17, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 17, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@macandcheese macandcheese merged commit f674964 into dev Jun 17, 2024
8 checks passed
@macandcheese macandcheese deleted the macandcheese/9620-carousel-keyboard-autoplay branch June 17, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants