Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): no longer hides input when a selected item chip is focused #9625

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

driskull
Copy link
Member

Related Issue: #6750

Summary

  • no longer hides input when a selected item chip is focused

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 18, 2024
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 18, 2024
@driskull driskull marked this pull request as ready for review June 18, 2024 15:42
@driskull driskull requested a review from a team as a code owner June 18, 2024 15:42
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 18, 2024
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️
😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌❌❌❌😶‍🌫️❌❌❌❌❌😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️❌😶‍🌫️
😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌❌😶‍🌫️❌❌😶‍🌫️❌😶‍🌫️
😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️❌❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️❌😶‍🌫️❌😶‍🌫️❌😶‍🌫️
😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️
😶‍🌫️❌❌❌😶‍🌫️❌❌❌❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️😶‍🌫️😶‍🌫️❌😶‍🌫️❌😶‍🌫️
😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️😶‍🌫️

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 18, 2024
@driskull driskull merged commit 24c45b3 into dev Jun 18, 2024
11 checks passed
@driskull driskull deleted the dris0000/combobox-dont-hide-input branch June 18, 2024 23:03
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants