Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordions #1015

Closed
julio8a opened this issue Jan 10, 2019 · 6 comments
Closed

Accordions #1015

julio8a opened this issue Jan 10, 2019 · 6 comments
Assignees
Milestone

Comments

@julio8a
Copy link
Contributor

julio8a commented Jan 10, 2019

No description provided.

@julio8a julio8a added the design label Jan 10, 2019
@julio8a julio8a added this to the 2.0.0 milestone Jan 10, 2019
@julio8a julio8a added this to Backlog in v2.0 (08/31/2019) Jan 10, 2019
@bstifle
Copy link

bstifle commented Jan 26, 2019

1 accordions
2 accordions dark
3 accordions stacked

@julio8a @macandcheese

@bstifle
Copy link

bstifle commented Jan 26, 2019

@julio8a please add mitch when he gets access to the board

@julio8a julio8a moved this from Backlog to Design in v2.0 (08/31/2019) Jan 26, 2019
@bstifle
Copy link

bstifle commented Jan 28, 2019

@mitc7862

@julio8a
Copy link
Contributor Author

julio8a commented Jan 28, 2019

Sweet! really like the variations. Especially the line version.

Is there a reason for the border-radius?
Seems out of place with all other elements and components being rectangular. Also, if the accordions have space in between (which is plausible), it might look odd with the negative space.

@bstifle
Copy link

bstifle commented Jan 28, 2019

i went with the border radius since i was using it for the inputs and dropdowns and stuff

I think you're right about just squaring them off. good point

@mitc7862
Copy link

@bstifle Cool cordz bro.

Consider figuring out how those margins respond to smaller screen widths. Those wide margins are going to crowd t content.

@julio8a julio8a moved this from Design to Implementation in v2.0 (08/31/2019) Mar 19, 2019
@julio8a julio8a assigned julio8a and unassigned bstifle Mar 19, 2019
@julio8a julio8a moved this from Implementation to Documentation in v2.0 (08/31/2019) Mar 20, 2019
@julio8a julio8a moved this from Documentation to Implementation in v2.0 (08/31/2019) Mar 21, 2019
@julio8a julio8a closed this as completed Apr 9, 2019
v2.0 (08/31/2019) automation moved this from Implementation to Completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2.0 (08/31/2019)
  
Completed
Development

No branches or pull requests

3 participants