Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions are hidden when control position is 'bottomleft' or 'bottomright' #224

Closed
jwasilgeo opened this issue Oct 11, 2019 · 2 comments · Fixed by #228
Closed

Suggestions are hidden when control position is 'bottomleft' or 'bottomright' #224

jwasilgeo opened this issue Oct 11, 2019 · 2 comments · Fixed by #228
Assignees
@jwasilgeo
Labels
Bug

Comments

@jwasilgeo
Copy link
Contributor

When providing either of these options during construction

  • position: 'bottomleft'
  • position: 'bottomright'

the suggestions menu is hidden under the bottom of the map's container. We might want to consider showing the suggestions above the <input ... > when the control is placed in either of the bottom map corners.

The offending node is <div class="geocoder-control-suggestions leaflet-bar" ... >.
@jwasilgeo jwasilgeo added the Bug label Oct 11, 2019
@jwasilgeo jwasilgeo self-assigned this Oct 12, 2019
@jwasilgeo
Copy link
Contributor Author

Work has begun on branch 224-bottom-position.

@jwasilgeo jwasilgeo mentioned this issue Oct 23, 2019
Merged
@jwasilgeo
Copy link
Contributor Author

https://github.com/Esri/esri-leaflet-geocoder/releases/tag/v2.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwasilgeo jwasilgeo

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

224-bottom-position Esri/esri-leaflet-geocoder
1 participant
@jwasilgeo