Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles disappear when zooming beyond 'maxNativeZoom' #743

Closed
octavm opened this issue Feb 17, 2016 · 5 comments · Fixed by #904
Closed

Tiles disappear when zooming beyond 'maxNativeZoom' #743

octavm opened this issue Feb 17, 2016 · 5 comments · Fixed by #904
Assignees
Labels

Comments

@octavm
Copy link
Contributor

octavm commented Feb 17, 2016

After the 'maxNativeZoom' level set on a tile loaded with L.esri.tiledMapLayer is reached, the tiles disappear instead of being loaded from the maxNativeZoom level and auto-scaled.

If the tile is loaded using the Leaflet L.tileLayer 'maxNativeZoom' works correctly.

I've prepared a demo to see the issue.

Two tiles have been added using the ESRI Leaflet addon and again using just Leaflet. After zooming in beyond the maximum zoom level where the tile has data (15) the ESRI tiles disappears whereas the Leaflet tile is scalled properly.

@octavm octavm changed the title Tiles disappear after 'maxNativeZoom' Tiles disappear when zooming beyond 'maxNativeZoom' Feb 17, 2016
@jgravois
Copy link
Contributor

thanks for this. the behavior definitely looks inappropriate to me. i should be able to take a closer look soon.

@patrickarlt
Copy link
Contributor

I took a look. I think this is related to changes we made to handle web mercator services at non-standard scale levels.

I think we need to use this._getZoomForUrl() instead of tilepoint.z in https://github.com/Esri/esri-leaflet/blob/master/src/Layers/TiledMapLayer.js#L62-L69. @jgravois Assigning to you so you can investigate.

@jgravois
Copy link
Contributor

I think we need to use this._getZoomForUrl()

based on my first pass, additional changes will be necessary to implement a fix.

@chriserickson
Copy link

Any updates on this?

Ran into this upgrading to Leaflet 1.0 and all of our layers with a maxNativeZoom stopped working correctly.

@jgravois
Copy link
Contributor

i took another look at this and was able to identify a fix, mostly due to @patrickarlt's characteristically good clue. the proposed patch can be found in #904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants