Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add full paths to libraries #750

Closed
jwitcoski opened this issue Feb 26, 2016 · 3 comments
Closed

Please add full paths to libraries #750

jwitcoski opened this issue Feb 26, 2016 · 3 comments

Comments

@jwitcoski
Copy link

//cdn.leafletjs.com/leaflet/v1.0.0-beta.2/leaflet.js

does not render when i use local browser on laptop. please change all your code to add https
https//cdn.leafletjs.com/leaflet/v1.0.0-beta.2/leaflet.js

@jgravois
Copy link
Contributor

thanks @jwitcoski, this is a good suggestion.

not sure everyone agrees, but it's considered an anti-pattern to use protocol relative URLs and the suggested alternative is to hardcode https instead whenever possible.

the problem with cdn.leafletjs.com is that it actually doesn't support https, so I suggest that we update the sample app in the README to point at the copy of leaflet hosted on jsdelivr instead.

a PR from anyone would be extremely appreciated. if no one submits in the near future, I'll go ahead and fix myself.

@jgravois
Copy link
Contributor

just realized that the references that actually need updated are not in the README, they are here

@jgravois
Copy link
Contributor

jgravois commented Mar 7, 2016

i've hardcoded links in our documentation site to use https when the resource is available over TLS/SSL.

thanks again for the feedback.

@jgravois jgravois closed this as completed Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants