Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideally show() should return an Iterator #45

Open
brainplot opened this issue Oct 18, 2023 · 2 comments
Open

Ideally show() should return an Iterator #45

brainplot opened this issue Oct 18, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brainplot
Copy link

Returning some iterator type instead of the whole Vec directly would allow consumers to have more control over how memory is allocated.

@EstebanBorai
Copy link
Owner

Hi @brainplot! Thanks for your interest in this crate!

I think returning an iterator is more flexible yet performant.

Perhaps we could have a major release using that approach instead of allocating the whole vector of network interfaces.

Are you interested in working on this?

@EstebanBorai EstebanBorai added enhancement New feature or request good first issue Good for newcomers labels Oct 20, 2023
@brainplot
Copy link
Author

Are you interested in working on this?

Yes, I can try to have a crack at this. I'm considering this crate for a project I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants