Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Buttons overlap with Physics Mod (Pro) #9

Open
nco2k opened this issue Mar 24, 2024 · 1 comment
Open

[Bug] Buttons overlap with Physics Mod (Pro) #9

nco2k opened this issue Mar 24, 2024 · 1 comment
Labels
compatibility Another mod is involved enhancement New feature or request

Comments

@nco2k
Copy link

nco2k commented Mar 24, 2024

bug

@Estecka Estecka added the compatibility Another mod is involved label Mar 25, 2024
@Estecka
Copy link
Owner

Estecka commented Mar 25, 2024

This issue comes from PhysicsMod.
Unfortunately, their mod is closed-source, so no-one but them have the ability fix this. I was able to peek at their code by decompiling the mod's jar, but I wouldn't be able to easily make change to it nor submit a PR for this.
This should be reported to them.

In PackruleMenu, I place the buttons by using Mojang's Gridwidget.adder (Yarn mappings), which is used to place all vanilla buttons. This method automatically adapts the menu's layout to its content, so this kind of issue would never happen amongst buttons registered in this way.

The issue is that physics Mod does not use the Gridwidget.adder, and instead places its button at fixed coordinates, assuming this position would always be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Another mod is involved enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants