Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subclass to next_session_times #24

Open
Esterni opened this issue Jul 18, 2020 · 2 comments
Open

Add subclass to next_session_times #24

Esterni opened this issue Jul 18, 2020 · 2 comments
Projects

Comments

@Esterni
Copy link
Owner

Esterni commented Jul 18, 2020

The attribute 26 "raceWeekCars" is actually a dictionary of car_ids
example from season 2865:
{"110":{"maxPctFuelFill":"","weightPenaltyKG":"","max_dry_tire_sets":3,"powerAdjustPct":""},"56":{"maxPctFuelFill":"","weightPenaltyKG":"","max_dry_tire_sets":3,"powerAdjustPct":""},"103":{"maxPctFuelFill":"","weightPenaltyKG":"","max_dry_tire_sets":3,"powerAdjustPct":""}}

@Esterni Esterni added this to To do in Initial Release Jul 19, 2020
@Esterni Esterni removed this from To do in Initial Release Jul 27, 2020
@Esterni Esterni added this to To do in v0.1.0-beta via automation Jul 27, 2020
@stucharo
Copy link

stucharo commented Aug 7, 2020

There's something odd happening in next_session_times() where response.json()["d"] returns an empty list (rather than the expected dict)for some series. So far it looks like this happens on:

2720 : eNASCAR Coca-Cola Series
2861 : iRacing Endurance Le Mans Series
2721 : NASCAR Road to Pro
2811 : Nurburgring Endurance Championship
2817 : Porsche Esports Sprint Challenge
2812 : Porsche TAG Heuer Esports Supercup
2908 : WoO Late Model WC Series

Has this behaviour been noticed before? Any ideas why it would happen on those particular series? I'll try and have a closer look later if we don't have any more insight yet.

Edit: Nevermind, it's series with no upcoming sessions. I'll modify the client to check this condition.

@Esterni
Copy link
Owner Author

Esterni commented Aug 10, 2020

It's interesting that it doesn't provide what the next session would be, even if it's further into the future.

It might be good to log a response that no sessions were detected, which usually indicates a series that has sessions spread far apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v0.1.0-beta
  
To do
Development

No branches or pull requests

2 participants