Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Schedule now" #51

Closed
edkoster opened this issue May 3, 2018 · 5 comments
Closed

"Schedule now" #51

edkoster opened this issue May 3, 2018 · 5 comments

Comments

@edkoster
Copy link
Contributor

edkoster commented May 3, 2018

Using version 0.4.0 on Magento 2.1.10 in production mode i get this error:

[Tue May 01 15:11:14.275469 2018] [proxy_fcgi:error] [pid 3946] [client 87.213.39.106:16732] AH01071: Got error 'PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to EthanYehuda\\CronjobManager\\Controller\\Adminhtml\\Config\\Job\\MassScheduleNow::__construct() must be an instance of Magento\\Framework\\View\\Result\\PageFactory, instance of Magento\\Framework\\ObjectManager\\ObjectManager given, called in /var/www/vhosts/score/httpdocs/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php on line 93 and defined in /var/www/vhosts/score/httpdocs/vendor/ethanyehuda/magento2-cronjobmanager/Controller/Adminhtml/Config/job/MassScheduleNow.php:19\nStack trace:\n #0 /var/www/vhosts/score/httpdocs/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(93): EthanYehuda\\CronjobManager\\Controller\\Adminhtml\\Config\\Job\\MassScheduleNow->__construct(Object(Magento\\Framework\\ObjectManager\\ObjectManager))\n #1 /var/www/vhosts/score/httpdocs/vendor/magento/framework/ObjectManager/Factory/Compiled.php(88): Magento\\Framework\\ObjectManager\\Factory\\AbstractFactory->createObject('EthanYehuda\\\\Cro...', Array)\n #2 ...\n', referer: https://support-score.itnova.nl/sitemanager_53RfIfauG6CnZGS/cronjobmanager/config/index/key/dd48cb763ad077fb2bf32652df3d040976b30970adfea962d9290b31a0943746/

when i use the "Schedule now" option on from the Job configuration.

i've done some debugging and found out that renaming
magento2-cronjobmanager/Controller/Adminhtml/Config/job
to
magento2-cronjobmanager/Controller/Adminhtml/Config/Job

solves the issue.

@Ethan3600
Copy link
Owner

Good catch! Would you mind opening a PR? I'll make a patch release after it gets merged in.

Thank you for using the CJM!

@edkoster
Copy link
Contributor Author

edkoster commented May 3, 2018

Thanks for your quick response.
I'll try to make some time for a pullrequest tomorrow.

@Ethan3600
Copy link
Owner

Awesome! Looking forward to it.

@edkoster
Copy link
Contributor Author

edkoster commented May 4, 2018

i've created #52

@Ethan3600
Copy link
Owner

I made a release for v1.5.1 and v0.4.1 to mitigate this issue. I'll go ahead and close this out, but feel free to comment if the error persists.

Thank you for your contribution @edkoster!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants