Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog: Regression introduced in copy code feature #628

Closed
EthanThatOneKid opened this issue Oct 21, 2022 · 0 comments · Fixed by #629
Closed

Blog: Regression introduced in copy code feature #628

EthanThatOneKid opened this issue Oct 21, 2022 · 0 comments · Fixed by #629
Assignees
@anhduy1202
Labels
bug Something isn't working

Comments

@EthanThatOneKid
Copy link
Owner

What happened?

In PR #621, a typo was introduced that shows some JavaScript code along with the markup.

Screenshot

image

Further refactoring

There might be a way to modularize the copy function. As suggested in: #621 (comment).
@EthanThatOneKid EthanThatOneKid added the bug Something isn't working label Oct 21, 2022
@anhduy1202 anhduy1202 self-assigned this Oct 23, 2022
@anhduy1202 anhduy1202 linked a pull request Oct 23, 2022 that will close this issue
Refactor copy function into its own folder + fix blog typo #629
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anhduy1202 anhduy1202

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor copy function into its own folder + fix blog typo anhduy1202/acmcsuf.com
2 participants
@EthanThatOneKid @anhduy1202