Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jamf host configuration #69

Merged
merged 1 commit into from Jan 30, 2018

Conversation

damien-rivet
Copy link
Owner

@damien-rivet damien-rivet commented Jan 30, 2018

Summary

Implements #64 by adding the basic element needed for configuring the URLRequest that will be returned / used later on by the framework.

Miscellaneous

Added SessionManager.
Added base request creation.
Added base errors.

Added SessionManager.
Added base request creation.
Added base errors.
@damien-rivet damien-rivet added this to the Release 0.3.0 milestone Jan 30, 2018
@damien-rivet damien-rivet self-assigned this Jan 30, 2018
@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #69 into develop will decrease coverage by 0.56%.
The diff coverage is 88.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
- Coverage    98.54%   97.97%   -0.57%     
===========================================
  Files           33       36       +3     
  Lines         1028     1087      +59     
===========================================
+ Hits          1013     1065      +52     
- Misses          15       22       +7
Impacted Files Coverage Δ
JamfKit/Sources/Models/BaseObject.swift 100% <ø> (ø) ⬆️
JamfKit/Sources/Session/SessionManagerError.swift 100% <100%> (ø)
...mfKit/Sources/Session/SessionManagerRequests.swift 100% <100%> (ø)
JamfKit/Sources/Session/SessionManager.swift 79.41% <79.41%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533badb...3aa29cb. Read the comment docs.

@damien-rivet damien-rivet merged commit f856463 into develop Jan 30, 2018
@damien-rivet damien-rivet deleted the feature/add-jamf-host-configuration branch January 30, 2018 12:29
damien-rivet added a commit that referenced this pull request Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
JamfKit v1.0.0 release
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant